| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Cleanup shadows variable warnings, round 1 |
| Date: | 2026-04-21 11:02:44 |
| Message-ID: | CAApHDvp=rx5GxM=yW8QhFF3noXtYt7LkOxJ7zkaPOzpti4Gm8w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 21 Apr 2026 at 19:02, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> PFA v8 - rebased and fixed a few new occurrences.
Which of these are new to v19? Can you separate those ones out? IMO,
we should commit at least those, as those won't cause any backpatching
pain.
I recall that I was motivated to commit the -Wshadow=compatible-local
ones as there'd been a few bugs with shadowed variables. There'd be
more of an argument to cause all this churn if it was for something
more than to make things better for clang users.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2026-04-21 11:19:27 | RE: Parallel Apply |
| Previous Message | Etsuro Fujita | 2026-04-21 10:55:55 | Re: Fix array-element quoting in postgres_fdw import statistics |