| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: Some clean-up work in get_cheapest_group_keys_order() |
| Date: | 2022-07-13 03:06:10 |
| Message-ID: | CAApHDvp=EzA3PAJ+wppB3U5JHn6UEkWQXuGHSJekS_bJer9p=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 13 Jul 2022 at 13:12, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > On Wed, 13 Jul 2022 at 11:02, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Agreed, but I think there are other instances of that idiom that
> >> should be cleaned up while you're at it.
>
> > Agreed. I imagine we should just do the remaining cleanup in master
> > only. Do you agree?
>
> No objection.
I've now pushed the original patch to 15 and master and also pushed a
cleanup commit to remove the list_truncate(list_copy instances from
master only.
Thanks for looking.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2022-07-13 03:08:33 | Re: enable/disable broken for statement triggers on partitioned tables |
| Previous Message | Kyotaro Horiguchi | 2022-07-13 02:41:40 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |