Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Greg Nancarrow <gregn4422(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path
Date: 2020-11-24 00:12:09
Message-ID: CAApHDvovEtBrw7ghZ7D=7nVJkcTdjME-eY+FeOC2NUvA6iRVaQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 24 Nov 2020 at 12:50, Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
> Hmmm, unfortunately this seems to break my build ...

> I think your commit needs to be fixed based on the following documentation:
>
> https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005fattribute.html#g_t_005f_005fhas_005fattribute

Agreed. I tested on https://godbolt.org/ with a GCC version < 5 and
updating to what's mentioned in the GCC manual works fine. What I had
did not.

Thanks for the report.

I pushed a fix.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-11-24 00:40:56 Re: remove spurious CREATE INDEX CONCURRENTLY wait
Previous Message kuroda.hayato@fujitsu.com 2020-11-24 00:01:49 RE: Terminate the idle sessions