| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: heapgettup() with NoMovementScanDirection unused in core? |
| Date: | 2023-01-31 21:56:31 |
| Message-ID: | CAApHDvosuiqhxLTTVabOwJ16wnHcpxzL_sNqwzo71h8i98zPXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 1 Feb 2023 at 03:02, Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
>
> On Tue, Jan 31, 2023 at 11:46:05PM +1300, David Rowley wrote:
> > Both can be easily fixed, so no need to submit another patch as far as
> > I'm concerned.
>
> I realized I forgot a commit message in the second version. Patch v1 has
> one.
I made a couple of other adjustments to the Asserts and comments and
pushed the result.
On further looking, I felt the Assert was better off done in
create_indexscan_plan() rather than make_index[only]scan(). I also put
the asserts in tableam.h and removed the heapam.c ones. The rest was
just comment adjustments.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2023-01-31 21:59:10 | Re: [PATCH] Fix old thinko in formula to compute sweight in numeric_sqrt(). |
| Previous Message | Peter Geoghegan | 2023-01-31 21:52:14 | Re: Show various offset arrays for heap WAL records |