Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
Date: 2024-03-25 01:58:15
Message-ID: CAApHDvopqUZA2ZLR2YawKWeztJohPxgjjwhXvckU-OOAwHPZoA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, 25 Mar 2024 at 13:07, Alexander Korotkov
<akorotkov(at)postgresql(dot)org> wrote:
> reindexdb: Add the index-level REINDEX with multiple jobs

This seems to cause a new compiler warning:

reindexdb.c: In function ‘reindex_one_database’:
reindexdb.c:437:45: warning: ‘indices_tables_cell’ may be used
uninitialized [-Wmaybe-uninitialized]
437 | indices_tables_cell = indices_tables_cell->next;
| ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
reindexdb.c:280:31: note: ‘indices_tables_cell’ was declared here
280 | SimpleStringListCell *indices_tables_cell;
| ^~~~~~~~~~~~~~~~~~~

which is causing problems in -Werror buildfarm members like mamba [1]

David

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mamba&dt=2024-03-25%2001%3A03%3A35

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Masahiko Sawada 2024-03-25 03:10:10 pgsql: Fix potential integer handling issue in radixtree.h.
Previous Message David Rowley 2024-03-25 01:32:05 pgsql: Allow planner to use Merge Append to efficiently implement UNION

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2024-03-25 02:03:23 Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Previous Message David Rowley 2024-03-25 01:43:54 Re: Properly pathify the union planner