| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Improvements in Copy From |
| Date: | 2020-07-14 05:43:41 |
| Message-ID: | CAApHDvopVVLDDG=6fu5NSRzLrXUuq-nsz8mUPjjjH==CahAqjw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 14 Jul 2020 at 17:22, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 2 Jul 2020 at 00:46, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter
> > that is not being used, it can be removed.
>
> This was raised in [1]. We decided not to remove it.
I just added a comment to the function to mention why we want to keep
the parameter. I hope that will save any wasted time proposing its
removal in the future.
FWIW, the function is inlined. Removing it will gain us nothing
performance-wise anyway.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-07-14 05:44:15 | Re: replication_origin and replication_origin_lsn usage on subscriber |
| Previous Message | k.jamison@fujitsu.com | 2020-07-14 05:34:01 | RE: Add MAIN_RELATION_CLEANUP and SECONDARY_RELATION_CLEANUP options to VACUUM |