Re: BUG #19533: Wrong results from WindowAgg run-condition pushdown on count() with EXCLUDE CURRENT ROW

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Chengpeng Yan <chengpeng_yan(at)outlook(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, "imchifan(at)163(dot)com" <imchifan(at)163(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #19533: Wrong results from WindowAgg run-condition pushdown on count() with EXCLUDE CURRENT ROW
Date: 2026-07-07 05:35:13
Message-ID: CAApHDvod3V=TKBB=Z3M-bPquzyznR1SYra77NWCTZLUUERm28g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, 7 Jul 2026 at 17:11, John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> - /* No ORDER BY clause then all rows are peers */
> ...
> + /* No ORDER BY clause and RANGE mode means all rows are peers. */
>
> Was the old comment wrong? Or are all rows still peers, but that's not
> sufficient to show monotonicity?

The test needed to be updated because detecting monotonically
increasing and decreasing in ROWS mode wasn't correct. The comment got
updated along with the test.

David

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Bharath Rupireddy 2026-07-07 07:38:02 Re: BUG #19536: UPDATE RETURNING OLD value is stale after concurrent update when table has a BEFORE UPDATE trigger
Previous Message Michael Paquier 2026-07-07 05:21:56 Re: BUG #19519: REPACK can fail due to missing chunk for toast value