Re: Default setting for enable_hashagg_disk

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Geoghegan <pg(at)bowt(dot)ie>, Jeff Davis <pgsql(at)j-davis(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Default setting for enable_hashagg_disk
Date: 2020-07-11 01:43:28
Message-ID: CAApHDvoOOsxTxb6xjdTBR0ZxXB9tQcqwXgY2tfF6QEKM5LG47Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Sat, 11 Jul 2020 at 13:36, David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> If we add a setting that defaults to work_mem then the benefit is severely reduced. You still have to modify individual queries, but the change can simply be more targeted than changing work_mem alone.

I think the idea is that this is an escape hatch to allow users to get
something closer to what PG12 did, but only if they really need it. I
can't quite understand why we need to leave the escape hatch open and
push them halfway through it. I find escape hatches are best left
closed until you really have no choice but to use them.

David

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message David G. Johnston 2020-07-11 01:53:23 Re: Default setting for enable_hashagg_disk
Previous Message David G. Johnston 2020-07-11 01:35:43 Re: Default setting for enable_hashagg_disk

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2020-07-11 01:53:23 Re: Default setting for enable_hashagg_disk
Previous Message Soumyadeep Chakraborty 2020-07-11 01:36:31 Re: Does TupleQueueReaderNext() really need to copy its result?