| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use appendStringInfoString and appendPQExpBufferStr where possible |
| Date: | 2020-10-14 08:05:16 |
| Message-ID: | CAApHDvoOEV=GzN8ereeXZNGFOi646=rN=Gma2+ikmjFOqyz_Tg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 28 Sep 2020 at 13:47, Hou, Zhijie <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote:
> Thanks for your response, combined them as a single patchset now.
I had a look over the three patches. All the changes look fine.
Thanks for working on it.
After a bit of grep work, I found about 6 times more calls that could
be improved. These involved searching for appendStringInfo calls that
could become appendStringInfoString calls and also appendPQExpBuffer
that could be converted to appendPQExpBufferStr.
I didn't really go hunting for any other calls that append a 1 char
string that don't use the Char variant of the function. So perhaps
there's more of those to be found.
I've attached the patch I ended up with. I plan on pushing this in the
next few days.
David
| Attachment | Content-Type | Size |
|---|---|---|
| fixup_some_appendStringInfo_calls.patch | text/plain | 30.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2020-10-14 08:10:56 | Re: Transactions involving multiple postgres foreign servers, take 2 |
| Previous Message | Heikki Linnakangas | 2020-10-14 07:40:12 | Re: scram-sha-256 broken with FIPS and OpenSSL 1.0.2 |