Re: [PATCH] Proposal to Enable/Disable Index using ALTER INDEX

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Robert Treat <rob(at)xzilla(dot)net>, Shayon Mukherjee <shayonj(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Gurjeet Singh <gurjeet(at)singh(dot)im>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Proposal to Enable/Disable Index using ALTER INDEX
Date: 2025-07-18 05:12:18
Message-ID: CAApHDvoLnr0nYRLygTf3Vht0uBvnMvM0VVPW=8vK8+51vYtECg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 18 Jul 2025 at 14:25, Sami Imseih <samimseih(at)gmail(dot)com> wrote:
> I’d argue we should not provide the ALTER option without the GUC, for
> more granular control.

If you mean the use_invisible_index GUC, then for transparency here,
I'm not in favour of that. I do understand that this might be useful
when trying to get a lagged hot-standby which is desperately
performing Seq Scans back up and running again while waiting on the
replay of the ALTER TABLE VISIBLE, but I just don't feel comfortable
being the committer/forever-owner of having a GUC that overwrites
something that's explicitly written in the system catalogue tables
that is disabled. It's just too magical for my liking. I don't think
we have anything like that today.

Other committers might feel differently, so if the general consensus
is ALTER TABLE+GUC, then I'll leave it to them. I'm by no means saying
this to try and influence the discussion here. If the ALTER TABLE
alone is not seen as useful and I'm the only one who thinks it would
be useful by itself, then I'll just back away from this and let
someone else pick it up.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2025-07-18 05:14:30 Re: Logical Replication of sequences
Previous Message Dilip Kumar 2025-07-18 04:43:54 Re: Improve pg_sync_replication_slots() to wait for primary to advance