On Sun, 30 Nov 2025 at 22:36, cca5507 <cca5507(at)qq(dot)com> wrote:
> Now we build the heap by using tuplesort_heap_insert(), which has a sift-up every call.
>
> To make it more efficient, I want to add tuplesort_heap_insert_unordered() and tuplesort_heap_build()
> just like binaryheap_add_unordered() and binaryheap_build().
>
> Thoughts?
For performance patches, you should include example workloads that
your patch speeds up. Include benchmark results with and without your
patch. Demonstrate you've not regressed any other workloads at the
expense of the ones you intend to speed up.
It's not up to reviewers to do this for you.
David