| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Streaming read-ready sequential scan code |
| Date: | 2024-04-04 03:45:16 |
| Message-ID: | CAApHDvo8_gFkhit1PzeS41CiKxgxkr5oxnkveLJ_cg6Pd6QihQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 4 Apr 2024 at 14:38, Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
> Looking at it in the code, I am wondering if we should call
> heap_page_prep() heap_scan_page_prep(). Just wondering if it is clear
> that it is prepping a page to be scanned. You choose whatever you
> think is best.
I ended up calling it heap_prepare_pagescan() as I started to think
prep/prepare should come first. I don't think it's perfect as the
intended meaning is heap_prepare_page_for_scanning_in_pagemode(), but
that's obviously too long.
I've pushed the v9-0001 with that rename done.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-04-04 04:11:31 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | David Rowley | 2024-04-04 03:28:58 | Re: Popcount optimization using AVX512 |