| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Memoize shows only the last execution's stats for parallel workers |
| Date: | 2026-10-12 07:16:27 |
| Message-ID: | CAApHDvo7rRStLt5xL27DYK=UKRSDwBuxrUE1QDrYv2=-sSeU_Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 12 Oct 2026 at 19:36, Tatsuya Kawata
<kawatatatsuya0913(at)gmail(dot)com> wrote:
> === Output on master
> Hits: 990 Misses: 10 Evictions: 0 Overflows: 0 Memory Usage: 1kB
> === With the patch
> Hits: 1980 Misses: 20 Evictions: 0 Overflows: 0 Memory Usage: 1kB
>
>
> The attached patch accumulates the stats instead of using memcpy(), as
> is already done for Parallel Bitmap Heap Scan (5a1e6df3b84). For Memory
> Usage, it keeps the maximum.
Yeah, I also noticed this when working on the patch you mentioned.
I'd say this one should be backpatched since it's misreporting.
I'll look into doing that once the tags for v19rc1 are applied.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Nidzwetzki | 2026-10-12 07:42:43 | Re: [PATCH] Fix PITR pause bypass when initial XLOG_RUNNING_XACTS has subxid overflow |
| Previous Message | Nitin Jadhav | 2026-10-12 07:14:24 | [PATCH] Fix recovery connection detail in EXEC_BACKEND builds |