Re: Pre-proposal: unicode normalized text

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Pre-proposal: unicode normalized text
Date: 2023-11-04 02:43:34
Message-ID: CAApHDvo5rstDhuSNB0B43TcPwBrqdmVzDLSJ5OYks1+unjf5vA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 4 Nov 2023 at 10:57, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Fri, Nov 3, 2023 at 9:01 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > On Fri, 3 Nov 2023 at 20:49, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> > > I think I just need to add unicode_category.c to @pgcommonallfiles in
> > > Mkvcbuild.pm. I'll do a trial commit tomorrow and see if that fixes it
> > > unless someone has a better suggestion.
> >
> > Thomas mentioned this to me earlier today. After looking I also
> > concluded that unicode_category.c needed to be added to
> > @pgcommonallfiles. After looking at the time, I didn't expect you to
> > be around so opted just to push that to fix the MSVC buildfarm
> > members.
>
> Shouldn't it be added unconditionally near unicode_norm.c? It looks
> like it was accidentally made conditional on openssl, which might
> explain why it worked for David but not for bowerbird.

Well, I did that one pretty poorly :-(

I've just pushed a fix for that. Thanks.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-11-04 02:53:14 Re: Moving forward with TDE [PATCH v3]
Previous Message Andres Freund 2023-11-04 02:38:07 Re: Moving forward with TDE [PATCH v3]