Re: BUG #15548: Unaccent does not remove combining diacritical characters

From: Hugh Ranalli <hugh(at)whtc(dot)ca>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: 2019-01-28 20:26:12
Message-ID: CAAhbUMN5NiPSNcs+_Z+bGfwa7aX+__1WeFOmZiDcCWF9xOqRiw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, 28 Jan 2019 at 02:27, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
wrote:

> Thanks for the reminder. I looked at this a couple of weeks ago when
> you ping me off-list, but I see we're still waiting for a rebase.
> Hugh, can you please post a new patch? The approach looks right to me
> (simply replace the composing diacritics with nothing), so if you post
> a new version I'll double check with that test case I came up with
> earlier, and then I'll be happy to commit it.
>

Hi Thomas,
My apologies; I hadn't realised I was supposed to do this. A rebased
version of patch 03 is attached. Let me know if you have any questions or
need any changes.

Best wishes,
Hugh

Attachment Content-Type Size
03-generate_unaccent_rules-remove-combining-diacritical-accents-02.patch text/x-patch 3.9 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2019-01-28 20:32:10 Re: Suggestion: include interruption method for \watch option (page 1922, PostgreSQL 11.1 Documentation)
Previous Message Bruce Momjian 2019-01-28 19:17:31 Re: psql and readline comments

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-01-28 20:32:29 Re: Proposed refactoring of planner header files
Previous Message Corey Huinker 2019-01-28 20:24:36 Re: Alternative to \copy in psql modelled after \g