Re: Patch: incorrect array offset in backend replication tar header

From: Brian Weaver <cmdrclueless(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Marko Tiikkaja <pgmail(at)joh(dot)to>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch: incorrect array offset in backend replication tar header
Date: 2012-09-27 22:12:14
Message-ID: CAAhXZGv8bN70CuQhVzC9nPzrK6moBur-EpK8k4rC448RMv1Wsg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus,

I probably just did a poor job of explaining what I wanted to try. I
was going to have the base backup open two connections; one to stream
the tar archive, the second to receive the wal files like
pg_receivexlog.

The wal files received on the second connection would be streamed to a
temporary file, with tar headers. Then when the complete tar archive
from the first header was complete received simply replay the contents
from the temporary file to append them to the tar archive.

Turns out that isn't necessary..... It was an idea borne from my
misunderstanding of how the pg_basebackup worked. The archive will
include all the wal files if I make wal_keep_segments high enough.

-- Brian

On Thu, Sep 27, 2012 at 6:01 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Tue, Sep 25, 2012 at 5:08 PM, Brian Weaver <cmdrclueless(at)gmail(dot)com> wrote:
>> Unless I misread the code, the tar format and streaming xlog are
>> mutually exclusive. Considering my normal state of fatigue it's not
>> unlikely. I don't want to have to set my wal_keep_segments
>> artificially high just for the backup
>
> Correct, you can't use both of those at the same time. That can
> certainly be improved - but injecting a file into the tar from a
> different process is far from easy. But one idea might be to just
> stream the WAL into a *separate* tarfile in this case.
>
>
> --
> Magnus Hagander
> Me: http://www.hagander.net/
> Work: http://www.redpill-linpro.com/

--

/* insert witty comment here */

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Brian Weaver 2012-09-27 22:18:36 Re: Patch: incorrect array offset in backend replication tar header
Previous Message Magnus Hagander 2012-09-27 22:03:04 Re: Patch: incorrect array offset in backend replication tar header