| From: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Jacob Champion <jchampion(at)timescale(dot)com>, Daniil Zakhlystov <usernamedt(at)yandex-team(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: libpq compression (part 2) |
| Date: | 2022-11-18 01:07:34 |
| Message-ID: | CAAhFRxja3=Jg6NTTbQtx-4N74FzW5TqOOFBH1LPXSVLzfgDpnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 17, 2022 at 7:09 AM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> Note that the above code was just changed in dce92e59b1.
Thanks!
> I don't know
> how that affects this patch set.
With dce92e59b1 it would be much easier to find a bug in the compression patch.
Some more notes about the patch. (sorry for posting review notes in so
many different messages)
1. zs_is_valid_impl_id(unsigned int id)
{
return id >= 0 && id < lengthof(zs_algorithms);
}
id is unsigned, no need to check it's non-negative.
2. This literal
{no_compression_name}
should be replaced by explicit form
{no_compression_name, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL}
3. Comments like "Return true if should, false if should not." are useless.
Thanks!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-11-18 01:23:58 | Re: Getting rid of SQLValueFunction |
| Previous Message | vignesh C | 2022-11-18 01:07:04 | Re: Typo in SH_LOOKUP and SH_LOOKUP_HASH comments |