| From: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Amcheck verification of GiST and GIN |
| Date: | 2023-03-26 22:17:02 |
| Message-ID: | CAAhFRxiHCWe_6AmqGWZqYEkgN_uQG3Jgw0WgPw+0zO3_D-q4DA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 19, 2023 at 4:00 PM Andrey Borodin <amborodin86(at)gmail(dot)com> wrote:
>
> Also, there are INCLUDEd attributes. Right now we just put them as-is
> to the bloom filter. Does this constitute a TOAST bug as in B-tree?
> If so, I think we should use a version of tuple formatting that omits
> included attributes...
> What do you think?
I've ported the B-tree TOAST test to GiST, and, as expected, it fails.
Finds non-indexed tuple for a fresh valid index.
I've implemented normalization, plz see gistFormNormalizedTuple().
But there are two problems:
1. I could not come up with a proper way to pfree() compressed value
after decompressing. See TODO in gistFormNormalizedTuple().
2. In the index tuples seem to be normalized somewhere. They do not
have to be deformed and normalized. It's not clear to me how this
happened.
Thanks!
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v26-0001-Refactor-amcheck-to-extract-common-locking-routi.patch | application/octet-stream | 18.6 KB |
| v26-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch | application/octet-stream | 32.3 KB |
| v26-0004-Add-GiST-support-to-pg_amcheck.patch | application/octet-stream | 30.7 KB |
| v26-0002-Add-gist_index_check-function-to-verify-GiST-ind.patch | application/octet-stream | 33.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2023-03-27 00:39:28 | Re: Request for comment on setting binary format output per session |
| Previous Message | Tom Lane | 2023-03-26 22:12:26 | Re: Request for comment on setting binary format output per session |