| From: | Dmitry Igrishin <dmitigr(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small patch to fix build on Windows |
| Date: | 2019-08-13 20:22:30 |
| Message-ID: | CAAfz9KNk1uUyv4zDB4BrR3M3+D-PjPtkvKs3etTQU6fgXvx8ig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
вт, 13 авг. 2019 г. в 06:19, Michael Paquier <michael(at)paquier(dot)xyz>:
>
> On Fri, Aug 09, 2019 at 11:21:52AM +0300, Dmitry Igrishin wrote:
> > Personally I don't care. I used || notation only in order to be
> > consistent, since this notation is already used in Solution.pm. If
> > this consistency is not required let me provide a patch with {}
> > notation. What do you think?
>
> We are talking about one place in src/tools/msvc/ using qq on HEAD.
> So one or the other is fine by me as long as we remain in the
> acceptable ASCII ranks.
Okay. 5th version of patch is attached.
| Attachment | Content-Type | Size |
|---|---|---|
| fix-mkvcbuild-5.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-08-13 20:43:57 | Re: Improve search for missing parent downlinks in amcheck |
| Previous Message | Peter Geoghegan | 2019-08-13 19:00:30 | Re: Use PageIndexTupleOverwrite() within nbtsort.c |