Re: bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane

From: Timon <timosha(at)gmail(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: "pgadmin-support(at)postgresql(dot)org" <pgadmin-support(at)postgresql(dot)org>, Gabriele Franch <franch(at)fbk(dot)eu>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane
Date: 2013-06-21 04:41:48
Message-ID: CAAeC-Suie+Xrkj2fur3VnDqPTegX=ehTJgh98z7jbAYYQvES5w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgadmin-support

i have tested it already, and it works great. Both problems are solved.
Thank you for your work :)

2013/6/20 Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>

> Hi Timon,
>
> I've sent patch to Dave (and, pgadmin-hackers) and he already checked-in.
>
> Can you please confirm both the behavior with the latest code?
> (1. Repeated messages and 2. Cancellation on Query Execution)
>
> If you can spend some time, that will be very helpful.
>
> On Tue, Jun 18, 2013 at 2:16 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Thanks Timon for point out.
>> I already know about this - I've made that mistake and will resolve it
>> very soon.
>> Made some changes in pgQueryThread class, which leads to this bug.
>>
>> Actually - I was busy with some other stuff, and couldn't spend time on
>> pgadmin3.
>>
>> On Tue, Jun 18, 2013 at 2:05 PM, Timon <timosha(at)gmail(dot)com> wrote:
>>
>>> seems that commit 140e8aee4cb5d423bb76ad81874e442d3e17b5c1 (Rewrite
>>> the debugger to resolve numerous known issues and instabilities mostly
>>> due to the threading code.) also broke ability to cancel query by
>>> pressing stop button in query editor
>>>
>>> 2013/5/16 Dave Page <dpage(at)pgadmin(dot)org>:
>>> > Ashesh - this appears to be related to the debugger changes. Can you
>>> > take a look please?
>>> >
>>> > Thanks.
>>> >
>>> > On Thu, May 16, 2013 at 2:07 PM, Gabriele Franch <franch(at)fbk(dot)eu>
>>> wrote:
>>> >> Hello,
>>> >> I'm using pgadmin 1.18.0 Alpha 1 (compiled from
>>> >>
>>> http://ftp.postgresql.org/pub/pgadmin3/release/v1.18.0-alpha1/src/pgadmin3-1.18.0-alpha1.tar.gz
>>> ).
>>> >>
>>> >> Messages are repeated multiple times in messages pane. Version 1.16.1
>>> >> does not expose this behavior.
>>> >>
>>> >> Example SQL:
>>> >>
>>> >> DROP FUNCTION IF EXISTS raise_something () CASCADE;
>>> >> CREATE OR REPLACE FUNCTION raise_something ()
>>> >> RETURNS VOID AS
>>> >> $BODY$
>>> >> BEGIN
>>> >> RAISE WARNING 'Something';
>>> >> RAISE NOTICE 'Something else';
>>> >> END
>>> >> $BODY$
>>> >> LANGUAGE plpgsql;
>>> >>
>>> >> select * from raise_something();
>>> >>
>>> >> Gabriele Franch
>>> >>
>>> >> --
>>> >> Sent via pgadmin-support mailing list (pgadmin-support(at)postgresql(dot)org
>>> )
>>> >> To make changes to your subscription:
>>> >> http://www.postgresql.org/mailpref/pgadmin-support
>>> >
>>> >
>>> >
>>> > --
>>> > Dave Page
>>> > Blog: http://pgsnake.blogspot.com
>>> > Twitter: @pgsnake
>>> >
>>> > EnterpriseDB UK: http://www.enterprisedb.com
>>> > The Enterprise PostgreSQL Company
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-support mailing list (pgadmin-support(at)postgresql(dot)org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-support
>>>
>>>
>>>
>>> --
>>> All bugs reserved
>>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
>

--
All bugs reserved

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2013-06-21 04:47:20 Re: bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane
Previous Message Ashesh Vashi 2013-06-20 19:39:54 Re: PATCH: Debugger Redesign

Browse pgadmin-support by date

  From Date Subject
Next Message Ashesh Vashi 2013-06-21 04:47:20 Re: bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane
Previous Message Ashesh Vashi 2013-06-20 16:32:29 Re: bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane