| From: | Dong Wook Lee <sh95119(at)gmail(dot)com> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) |
| Date: | 2022-02-09 14:55:21 |
| Message-ID: | CAAcByaL6aPLbFK6WfT-U6PzvwPUx3QxxCo64smTvS=4zE_mqsg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Oops, I realized that I made a mistake in my patch and now I have corrected it.
2022년 2월 9일 (수) 오후 11:33, Dong Wook Lee <sh95119(at)gmail(dot)com>님이 작성:
>
> Hi,
>
> I've applied your patch. I think it's reasonable.
> but IMHO It looks more complicated to read because of many conditions
> in if statement.
> so what about just moving up if-statement?
>
> Thanks.
> Dong Wook Lee
>
> 2022년 2월 9일 (수) 오후 7:56, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>님이 작성:
> >
> > Hi,
> >
> > I think this change can improve this particular function by avoiding touching value if not needed.
> > Test if not isnull is cheaper than test TupleDescAttr is -1.
> >
> > best regards,
> >
> > Ranier Vilela
| Attachment | Content-Type | Size |
|---|---|---|
| v3_tiny_improvemnt_toast_helper.patch | application/octet-stream | 654 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Sharma | 2022-02-09 15:06:31 | Re: Identify missing publications from publisher while create/alter subscription. |
| Previous Message | Dagfinn Ilmari Mannsåker | 2022-02-09 14:34:08 | Re: Replacing TAP test planning with done_testing() |