From: | Dong Wook Lee <sh95119(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_buffercache: add sql test |
Date: | 2022-08-02 00:50:05 |
Message-ID: | CAAcBya+ikpTfO6aXV4MScWqK=03_8z5oJMLy0CJQP=L3QiXrNg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I've been missing what I have to add to the .gitignore file when I
write the test.
I will refer to it when I write the test code from now on.
Thank you.
2022년 7월 31일 (일) 오전 4:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>님이 작성:
>
> Dong Wook Lee <sh95119(at)gmail(dot)com> writes:
> > I just wrote a test code for the `pg_buffercache` extension which
> > doesn't not have test code.
>
> Pushed with minor adjustments. Some notes:
>
> * A .gitignore file is needed so that "git status" won't whine after
> running the test. This tends to be pretty much boilerplate; I copied
> it from another contrib directory.
>
> * Pay attention to "git diff --check" formatting warnings. In this
> case it bleated about an extra blank line at the end of the .sql file.
>
> * I didn't care for the direct use of pg_show_all_settings(). The
> official API there is the pg_settings view, and there's no need for
> this test to get friendly with the view's internals.
>
> Thanks for the patch!
>
> regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2022-08-02 01:19:25 | Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c) |
Previous Message | Andres Freund | 2022-08-02 00:39:47 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |