| From: | James Coleman <jtc331(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-03-05 22:01:06 |
| Message-ID: | CAAaqYe_kpBUEkKXLRYfspu05p0wgj_n3_tORStDfCvLUpWUbRA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 21, 2020 at 9:37 AM James Coleman <jtc331(at)gmail(dot)com> wrote:
> That being said, the patch also needs some more work on improving
> EXPLAIN ANALYZE output (perhaps min/max/mean or median of
> memory usage number of groups in each sort mode), and I think it's far
> more feasible that I can tackle that piecemeal before the next CF.
>
I'm looking at this now, and realized that at least for parallel plans the
current patch tracks the tuplesort instrumentation whether or not an
EXPLAIN ANALYZE is in process.
Is this fairly standard for executor nodes? Or is it expected to condition
some of this tracking based on whether or not an ANALYZE is running?
I'm found EXEC_FLAG_EXPLAIN_ONLY but no parallel for analyze. Similarly the
InstrumentOption bit flags on the executor state seems to indicate whether
specific ANALYZE options should be enabled, but I haven't yet seen anything
conditioned solely on whether an ANALYZE is in flight. Could someone point
me in the right direction is this is expected?
Thanks,
James
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-03-05 22:46:44 | Re: Allowing ALTER TYPE to change storage strategy |
| Previous Message | David Rowley | 2020-03-05 21:52:33 | Re: Berserk Autovacuum (let's save next Mandrill) |