From: | James Coleman <jtc331(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Correct docs re: rewriting indexes when table rewrite is skipped |
Date: | 2022-03-31 14:13:57 |
Message-ID: | CAAaqYe_VP0jjcaJnPzz9Xu4hBPG-WT4YVbS1S+rcqLM4c155cA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 31, 2022 at 9:43 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Thu, Mar 31, 2022 at 9:17 AM James Coleman <jtc331(at)gmail(dot)com> wrote:
> > All right, thanks for feedback. Attached is v2 with such a change.
> > I've not included examples, and I'm about 50/50 on doing so. What are
> > your thoughts on adding in parens "e.g., changing from varchar to text
> > avoids rebuilding indexes while changing from text to a domain of text
> > with a different collation will require rebuilding indexes"?
>
> On the patch, I suggest that instead of saying "can verify that sort
> order and/or hashing semantics are unchanged" you say something like
> "can verify that the new index would be logically equivalent to the
> current one", mostly because I do not think that "and/or" looks very
> good in formal writing.
Agreed re: "and/or".
> I think it would be fine to include examples, but I think that the
> phrasing you suggest here doesn't seem great. I'm not sure how to fix
> it exactly. Maybe it needs a little more explanation?
Is the attached more along the lines of what you were thinking?
Thanks,
James Coleman
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Docs-Index-rebuilding-is-sometimes-skipped-along-.patch | application/octet-stream | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2022-03-31 14:14:25 | Re: unlogged sequences |
Previous Message | Tom Lane | 2022-03-31 14:11:41 | Re: Commitfest Update |