| From: | James Coleman <jtc331(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-03-05 23:37:56 |
| Message-ID: | CAAaqYe_Rr4o24RdixZqStymRed5LeUzcq19HdeCXXhpLs90tpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 5, 2020 at 5:53 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> James Coleman <jtc331(at)gmail(dot)com> writes:
> > I'm looking at this now, and realized that at least for parallel plans
> the
> > current patch tracks the tuplesort instrumentation whether or not an
> > EXPLAIN ANALYZE is in process.
>
> > Is this fairly standard for executor nodes? Or is it expected to
> condition
> > some of this tracking based on whether or not an ANALYZE is running?
>
> No, it's entirely not standard. Maybe you could make an argument that
> it's too cheap to bother making it conditional, but without a convincing
> argument for that, it needs to be conditional.
>
That's what I figured, but as I mentioned I've having trouble figuring out
how the fact that an analyze is in flight is determined. I assume it's
something that lives of the EState or similar, but I'm not seeing anything
obvious.
Thanks
James
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-03-05 23:45:37 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | Aleksei Ivanov | 2020-03-05 23:27:05 | Re: Proposal: PqSendBuffer removal |