Re: Nicer error when connecting to standby with hot_standby=off

From: James Coleman <jtc331(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, David Steele <david(at)pgmasters(dot)net>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Nicer error when connecting to standby with hot_standby=off
Date: 2021-03-09 14:19:37
Message-ID: CAAaqYe9yw6XUdP94RbSFi_tuaE0LAm8LC-2E6MJSZqZxw+P32Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 9, 2021 at 9:17 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Mar-09, James Coleman wrote:
>
> > Yes, I think they both agreed on the "DETAIL: Hot standby mode is
> > disabled." message, but that alternative meant not needing to add any
> > new signals and pm states, correct?
>
> Ah, I see! I was thinking that you still needed the state and signal in
> order to print the correct message in hot-standby mode, but that's
> (obviously!) wrong. So you're right that no signal/state are needed.

Cool. And yes, I'm planning to update the patch soon.

Thanks,
James

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-03-09 14:24:10 Re: shared-memory based stats collector
Previous Message Alvaro Herrera 2021-03-09 14:17:22 Re: Nicer error when connecting to standby with hot_standby=off