| From: | James Coleman <jtc331(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-03-15 19:09:52 |
| Message-ID: | CAAaqYe-14hsP437g6yoQswfizfexRBR4GM+QduKdjyPRfcUczw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 13, 2020 at 4:22 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Also, I wonder if it would be better to modify our policies so that we
> > update typedefs.list more frequently. Some people include additions
> > with their commits, but it's far from SOP.
>
> Perhaps. My own workflow includes pulling down a fresh typedefs.list
> from the buildfarm (which is trivial to automate) and then adding any
> typedefs invented by the patch I'm working on. The latter part of it
> makes it hard to see how the in-tree list would be very helpful; and
> if we started expecting patches to include typedef updates, I'm afraid
> we'd get lots of patch collisions in that file.
>
> I don't have any big objection to updating the in-tree list more often,
> but personally I wouldn't use it, unless we can find a better workflow.
How does the buildfarm automate generating the typedefs list? Would it
be relatively easy to incorporate that into a tool that someone could
use locally with pgindent?
Thanks,
James
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2020-03-15 19:33:51 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | Kirill Bychik | 2020-03-15 18:52:18 | Re: WAL usage calculation patch |