| From: | Jacob Champion <jchampion(at)timescale(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com> |
| Subject: | Re: Making empty Bitmapsets always be NULL |
| Date: | 2023-03-01 21:35:08 |
| Message-ID: | CAAWbhmiNCsQdiRwfET=OU66Z4kES9Bm_AATwj1uRn3=r43HXtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 28, 2023 at 1:59 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I also discovered that nodeAppend.c is relying on bms_del_members
> not reducing a non-empty set to NULL, because it uses the nullness
> of appendstate->as_valid_subplans as a state boolean.
I seem to recall that Deep and I tripped into this during the zedstore
column projection work. I think we started out using NULL as a
sentinel value for our bitmaps, too, and it looked like it worked,
until it didn't... so +1 to the simplification.
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jehan-Guillaume de Rorthais | 2023-03-01 21:45:58 | Re: Memory leak from ExecutorState context? |
| Previous Message | Andres Freund | 2023-03-01 21:32:58 | Re: buildfarm + meson |