Re: [PATCH] Expose port->authn_id to extensions and triggers

From: Jacob Champion <jchampion(at)timescale(dot)com>
To: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Joe Conway <mail(at)joeconway(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "rjuju123(at)gmail(dot)com" <rjuju123(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
Date: 2022-08-16 16:09:03
Message-ID: CAAWbhmi2syrCupOCG+K63fBVCTEbsCQFSUEgYWpxUxKDE4Gi3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

On Fri, Aug 12, 2022 at 6:34 AM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com> wrote:
> +typedef struct
> +{
> + /*
> + * Authenticated identity. The meaning of this identifier is
> dependent on
>
> has to be replaced by:
>
> +typedef struct ClientConnectionInfo
> +{
> + /*
> + * Authenticated identity. The meaning of this identifier is
> dependent on

Okay, will do in the next patch (coming soon).

> + * Authenticated identity. The meaning of this identifier is
> dependent on
>
> There is one extra space before "The"

This comment block was just moved verbatim; the double-spaced
sentences were there before.

> From a coding style point of view, shouldn't "ClientConnectionInfo
> MyClientConnectionInfo;" be moved to the top of the file?

The style in this file seems to be to declare the variables at the top
of the section in which they're used. See the sections for "User ID
state" and "Library preload support".

Thanks,
--Jacob

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-08-16 16:32:30 Re: Add find_in_log() and advance_wal() perl functions to core test framework (?)
Previous Message Tom Lane 2022-08-16 16:08:23 Re: Making Vars outer-join aware