Re: [PATCH] pg_dump: Sort overloaded functions in deterministic order

I agree, good suggestion, I just didn't know how to implement it without a
new field. I'll make a new attempt to get it right.

On Thursday, July 5, 2012, Tom Lane wrote:

> Joel Jacobson <joel(at)trustly(dot)com <javascript:;>> writes:
> > New version, made a typo in last one.
>
> I'm not particularly happy with the idea of adding a sortkey field to
> DumpableObject as such, when most object types don't need it. That just
> bloats the code and pg_dump's memory consumption. It would be better to
> modify the already-existing object-type-specific special cases in
> DOTypeNameCompare to take additional information into account as needed.
>
> BTW, I see no reason to be adding extra calls of
> pg_get_function_identity_arguments. What is wrong with the funcsig or
> aggsig strings that the code already computes?
>
> regards, tom lane
>