Stop masking visibility information during WAL consistency checking

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: surya poondla <suryapoondla4(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Zhijie Hou <houzhijie22(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Stop masking visibility information during WAL consistency checking
Date: 2026-11-20 18:53:59
Message-ID: CAAKRu_bozJHE=Za4o1yZaPmW_rjG5DrUSDfEjOZkjvmaeN+EEA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Today wal_consistency_checking compares neither the bitmap on VM pages
nor the PD_ALL_VISIBLE flag on heap pages. The attached patches make
it compare both. We discussed checking the VM bitmap in the WAL_LOG
CREATE DATABASE thread [1], and I proposed checking PD_ALL_VISIBLE in
the thread about registering VM buffers for clears [2]. I think we
should do both on master.

- Melanie

[1] https://postgr.es/m/2889116c-7da1-4ab0-b10a-3fadb99c24e7@gmail.com
[2] https://postgr.es/m/CAAKRu_aRdQ6RjneKeQh9%2BRVMFgMrtjTYFX%3DzDgBdSiQ8JDs6Jg%40mail.gmail.com

Attachment Content-Type Size
v1-0001-Stop-masking-visibility-map-bits-during-WAL-consi.patch text/x-patch 17.7 KB
v1-0002-Stop-masking-PD_ALL_VISIBLE-when-checking-WAL-con.patch text/x-patch 1.6 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Muzzammil Sarwar 2026-11-20 19:11:11 Re: [PATCH] Fix leak when a plpgsql exception block catches an error from CALL
Previous Message Gilles Darold 2026-11-20 18:36:23 Re: Backpatch for fix simplehash to preserve consistency in case of OOM