Re: Unlogged rel fake lsn vs GetVictimBuffer()

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: Unlogged rel fake lsn vs GetVictimBuffer()
Date: 2026-03-11 18:03:36
Message-ID: CAAKRu_b2ujALda3VrGOzoQT7Nm3WRrOEVWPnmHY9qt0R4nYVNA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 10, 2026 at 3:46 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> Now, I'm thinking that I should allow BufferNeedsWALFlush() to be
> called on local buffers. I removed it in v2 because Andres mentioned
> it could never happen when called by StrategyRejectBuffer() (because
> we don't use strategies on local buffers), but there's no reason
> BufferNeedsWALFlush() can't be used more widely in the future.

Well, due to 82467f627bd478569de, this is now a tiny one-liner. Will
push in an hour or so barring objections.

- Melanie

Attachment Content-Type Size
v3-0001-Avoid-WAL-flush-checks-for-unlogged-buffers-in-Ge.patch text/x-patch 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-03-11 18:04:52 [PATCH] Add missing stats_reset column to pg_statio_all_sequences view
Previous Message Alexandre Felipe 2026-03-11 18:03:34 Re: Addressing buffer private reference count scalability issue