| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Jingtang Zhang <mrdrivingduck(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: [PATCH] vacuum: stop using stream ring after failsafe |
| Date: | 2026-08-07 15:27:40 |
| Message-ID: | CAAKRu_awgKs91nW0wSkyBWktPTZoJdbzMswyPZMXRt=Q2fBJBQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 7, 2026 at 11:20 AM Jingtang Zhang <mrdrivingduck(at)gmail(dot)com> wrote:
>
> One question: are there general guidelines for keeping argument counts
> low in hot PostgreSQL functions, or is this mainly assessed case by case?
We don't worry about it unless it is the bottleneck in some workload
-- like if you have a workload where you can notice a performance
improvement by changing the number of arguments. The
StartReadBuffersImpl() thing came about when we committed the read
stream code and someone noticed regressions for fully cached
sequential scans as compared to without the read stream code. The read
stream adds its own overhead, so Andres/Thomas/Bilal and others
embarked on a journey to try to win back performance for that use case
by chipping away at various things guided by careful profiling and
benchmarking.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Sontakke | 2026-08-07 15:51:25 | Re: Hot standby accepts connections (giving wrong results) before consistency after crash reset |
| Previous Message | Jingtang Zhang | 2026-08-07 15:19:52 | Re: [PATCH] vacuum: stop using stream ring after failsafe |