Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Date: 2025-07-11 22:19:15
Message-ID: CAAKRu_ac4vUdU-U3ax8j=N8y2OM9-pbFZhafLVfzDOM8MtzvvA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 9, 2025 at 5:59 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Thu, Jun 26, 2025 at 6:04 PM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
> >
> > Rebased in light of recent changes on master:
>
> This needed another rebase, and, in light of the discussion in [1],
> I've also removed the patch to add heap wrappers for setting pages
> all-visible.

Andrey Borodin made the excellent point off-list that I forgot to
remove the xl_heap_visible struct itself -- which is rather important
to a patch set purporting to eliminate xl_heap_visible! New version
attached.

- Melanie

Attachment Content-Type Size
v4-0002-Eliminate-xl_heap_visible-in-COPY-FREEZE.patch application/x-patch 10.2 KB
v4-0003-Make-heap_page_is_all_visible-independent-of-LVRe.patch application/x-patch 5.1 KB
v4-0005-Use-xl_heap_prune-record-for-setting-empty-pages-.patch application/x-patch 5.8 KB
v4-0001-Add-assert-to-heap_prune_record_unchanged_lp_norm.patch application/x-patch 963 bytes
v4-0004-Eliminate-xl_heap_visible-from-vacuum-phase-III.patch application/x-patch 24.4 KB
v4-0010-Eliminate-xl_heap_visible-from-vacuum-phase-I-pru.patch application/x-patch 25.7 KB
v4-0009-Update-VM-in-pruneheap.c.patch application/x-patch 12.7 KB
v4-0006-Combine-lazy_scan_prune-VM-corruption-cases.patch application/x-patch 7.1 KB
v4-0008-Find-and-fix-VM-corruption-in-heap_page_prune_and.patch application/x-patch 11.7 KB
v4-0007-Combine-vacuum-phase-I-VM-update-cases.patch application/x-patch 5.6 KB
v4-0011-Remove-xl_heap_visible-entirely.patch application/x-patch 22.3 KB
v4-0012-Allow-on-access-pruning-to-set-pages-all-visible.patch application/x-patch 29.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul Jungwirth 2025-07-11 22:22:01 Re: Foreign key isolation tests
Previous Message Nathan Bossart 2025-07-11 21:58:30 Re: Improve LWLock tranche name visibility across backends