| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Why clearing the VM doesn't require registering vm buffer in wal record |
| Date: | 2026-07-15 21:58:08 |
| Message-ID: | CAAKRu_aRdQ6RjneKeQh9+RVMFgMrtjTYFX=zDgBdSiQ8JDs6Jg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 14, 2026 at 3:42 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> I've also finished all branch versions of this. Each one's code
> differs, but I've managed to keep the commit messages the same, which
> should help release notes. Note that REL_19_STABLE bumps
> XLOG_PAGE_MAGIC. This would keep us from having to maintain the
> backwards compatibility code there, which I think is what we want.
> Here are those branches.
I've pushed the main commits to all branches where needed. There are
three patches remaining that I proposed for master that do assorted
validations: visibility map and PD_ALL_VISIBLE flag validations and
some validation in the WAL machinery that registered buffers get used.
I plan to commit 0001 and 0003 once my other patches have gone through
the buildfarm. I'm considering holding onto 0002 until I add
WAL-logging to the VM corruption repair code in
heap_page_fix_vm_corruption() -- without which,
wal_consistency_checking could fail for pages that had corruption
fixed.
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-VM-corruption-check-to-verify_heapam.patch | application/x-patch | 2.2 KB |
| v6-0002-Stop-masking-PD_ALL_VISIBLE-when-checking-WAL-con.patch | application/x-patch | 1.6 KB |
| v6-0003-xlog-Verify-all-block-references-are-used-during-.patch | application/x-patch | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-07-15 22:10:48 | Re: pg_hosts: Add pg_hosts_file_rules() |
| Previous Message | Bruce Momjian | 2026-07-15 21:55:13 | Re: First draft of PG 19 release notes |