| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: Streaming read-ready sequential scan code |
| Date: | 2024-04-05 15:31:08 |
| Message-ID: | CAAKRu_aHj77xyTo0eVQ1CkMp=ewV3TSLbqpEDqvz6zDVVq7QVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 4, 2024 at 12:39 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2024-04-04 22:37:39 +1300, Thomas Munro wrote:
> > On Thu, Apr 4, 2024 at 10:31 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > Alright what about this?
>
> I think it's probably worth adding a bit more of the commit message to the
> function comment. Yes, there's a bit in one of the return branches, but that's
> not what you're going to look at when just checking what the function does.
Agreed about the comment. I kept thinking that BAS_BULKREAD should
maybe return nbuffers - 1, but I couldn't convince myself why.
Otherwise v2-0001-Allow-BufferAccessStrategy-to-limit-pin-count LGTM.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-04-05 15:38:11 | Re: Popcount optimization using AVX512 |
| Previous Message | Jelte Fennema-Nio | 2024-04-05 15:28:03 | Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs |