Re: pgsql: Reduce scope of heap vacuum per_buffer_data

On Tue, Feb 18, 2025 at 9:30 AM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> Reduce scope of heap vacuum per_buffer_data
>
> Move lazy_scan_heap()'s per_buffer_data variable into a tighter scope.
> In lazy_scan_heap()'s phase I heap vacuuming, the read stream API
> returns a pointer to the next block number to vacuum. As long as
> read_stream_next_buffer() returns a valid buffer, per_buffer_data should
> always be valid.

Realized I forgot an important word in the commit message.
per_buffer_data doesn't point to the block number. It points to info
about the next block. Commit message should say "the read stream API
returns a pointer to information about the next block to vacuum". Oh
well... There is nothing I can do now.

- Melanie