| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | "Li, Yong" <yoli(at)ebay(dot)com> |
| Cc: | "Debnath, Shawn" <sdn(at)ebay(dot)com>, "Shyrabokau, Anton" <antons(at)ebay(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Separate HEAP WAL replay logic into its own file |
| Date: | 2024-06-18 12:42:39 |
| Message-ID: | CAAKRu_ZmJRbZeKFRc=T6u5zKuHo0mXaKOYmae-qkDb_SZW1n0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 17, 2024 at 9:12 PM Li, Yong <yoli(at)ebay(dot)com> wrote:
>
> As a newcomer, when I was walking through the code looking for WAL replay related code, it was relatively easy for me to find them for the B-Tree access method because of the “xlog” hint in the file names. It took me a while to find the same for the heap access method. When I finally found them (via text search), it was a small surprise. Having different file organizations for different access methods gives me this urge to make everything consistent. I think it will make it easier for newcomers, and it will reduce the mental load for everyone to remember that heap replay is inside the heapam.c not some “???xlog.c”.
That makes sense. The branch for PG18 has not been cut yet, so I
recommend registering this patch for the July commitfest [1] so it
doesn't get lost.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2024-06-18 12:45:25 | Re: Missing docs for new enable_group_by_reordering GUC |
| Previous Message | Peter Eisentraut | 2024-06-18 12:30:55 | Re: jsonpath: Missing regex_like && starts with Errors? |