| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum. |
| Date: | 2025-07-01 18:33:51 |
| Message-ID: | CAAKRu_ZjMi9XN8BtM40_sau1p0fRJnxOQ8QEBFB_GmbWZnTciw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 1, 2025 at 12:01 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> I've attached the updated patches for master and backbranches (v17 and
> v18). Please review these patches.
All look good to me. One nitpick that is up to you if you want to
change: the comment
* Return the number of tuples deleted from the page during HOT pruning.
is at the top of the function block comment for lazy_scan_prune() in
your patch. Most of the function block comments in vacuumlazy.c list
the return value last after describing the other parameters and use
"Returns" as opposed to the imperative conjugation "Return".
Thanks so much for finding and fixing my bug!
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-07-01 19:00:54 | Re: pg_get_multixact_members not documented |
| Previous Message | Peter Geoghegan | 2025-07-01 18:28:24 | Re: Making Row Comparison NULL row member handling more robust during skip scans |