| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, surya poondla <suryapoondla4(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Zhijie Hou <houzhijie22(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Stop masking visibility information during WAL consistency checking |
| Date: | 2026-11-20 23:30:04 |
| Message-ID: | CAAKRu_ZU-GpYaOHqzs_v3dx=k9VhsnDjTzxKPCzEpoWR9w6AFg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 20, 2026 at 6:17 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> > Stop masking PD_ALL_VISIBLE, as doing so can only conceal real bugs.
>
> Claude pointed out that wal_consistency_checking can trigger an error
> with 0002. This uses very specific flags, but both
> full_page_writes=off and disabled data checksums are supported, so it
> seems like a plausible scenario.
Ah, right, I forgot that when we only sets the VM bits and both
checksums/wal_log_hints are off, we can set PD_ALL_VISIBLE without
advancing the heap page LSN. So, I suppose we can't do 0002. I'll
replace it with a replacement of the comment explaining why we have to
mask PD_ALL_VISIBLE. Thanks!
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-11-20 23:40:58 | Re: Postmaster PANIC on a standby with slot synchronization enabled |
| Previous Message | Hannu Krosing | 2026-11-20 23:21:49 | Re: ZSTD TOAST compression, and an extensible compression method encoding |