Re: [PATCH] vacuum: stop using stream ring after failsafe

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jingtang Zhang <mrdrivingduck(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: [PATCH] vacuum: stop using stream ring after failsafe
Date: 2026-08-07 14:16:12
Message-ID: CAAKRu_ZSzB-PG8mY934rpRVdsmgArTzZkZPmwFYVNSmJ+-KMoA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 6, 2026 at 6:16 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Thu, Aug 6, 2026 at 6:04 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Melanie Plageman <melanieplageman(at)gmail(dot)com> writes:
> > > Okay, I pushed it, but right after pushing it I suddenly had the
> > > thought, omg, it loops through all the ReadBuffersOperations and sets
> > > them to NULL for _every_ page after entering failsafe mode. And we
> > > obviously ought to fix that. Proposed patch to do that with a simple
> > > local variable is attached. This time I'll let this one sit for longer
> > > before pushing to avoid mistakes like last time.
> >
> > Don't wait too long, unless you want to revert 112c26838 et al
> > till after the upcoming releases. As things stand right now,
> > we'd ship what is in git.
>
> roger that. I'm planning to push in the morning which will be before
> Saturday's freeze.

Committed and backpatched.

- Melanie

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2026-08-07 14:21:32 Re: Support EXCEPT for TABLES IN SCHEMA publications
Previous Message Dilip Kumar 2026-08-07 14:11:35 Re: Proposal: Conflict log history table for Logical Replication