| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |
| Date: | 2019-04-24 19:08:24 |
| Message-ID: | CAAKRu_YxHYQzWx5OZc=MZ_3-twah8NuKoV5USGeaGZ8-amnCxA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 23, 2019 at 1:06 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> There are three functions in fd.c that have a dependency on the
> temp tablespace info having been set up:
> OpenTemporaryFile
> GetTempTablespaces
> GetNextTempTableSpace
> This patch makes the first of those automatically set up the info
> if it's not done yet. The second one has always had an assertion
> that the caller did it already, and now the third one does too.
> An about equally plausible change would be to make all three
> call PrepareTempTablespaces, but there are so few callers of the
> second and third that I'm not sure that'd be better. Thoughts?
>
>
I think an assertion is sufficiently clear for GetNextTempTableSpace based
on
what it does and its current callers. The same is probably true for
GetTempTableSpaces.
--
Melanie Plageman
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-04-24 19:17:06 | Re: Calling PrepareTempTablespaces in BufFileCreateTemp |
| Previous Message | Alvaro Herrera | 2019-04-24 19:01:18 | Re: pg_dump partitions can lead to inconsistent state after restore |