| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Rogers Wang <rogers(dot)ww(at)qq(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts |
| Date: | 2026-09-14 15:49:28 |
| Message-ID: | CAAKRu_YgVVSjr=EUJQbTN1gTKbzf7=T22H13x1d0eGGw+vH4ww@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 11, 2026 at 4:44 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> > In master, it probably makes sense to change back the signature of
> > visibilitymap_set() to report if it did actually set the bit(s) and
> > then use that to decide whether to set the page LSN. Unless we don't
> > think it is too late in 19 to change the visibilitymap_set() API. It
> > does mean all the other callers of visibilitymap_set() are going to
> > discard the return value, but maybe that's okay?
>
> Since we are putting out a beta 4, I feel fine about changing the
> visiblitymap_set() API back. Here is a patch that does that.
I've pushed a fix for this and marked the open item as resolved.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2026-09-14 16:02:30 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | Matthias van de Meent | 2026-09-14 15:45:09 | Re: [PATCH] pg_dump: Restore extension config table data before user objects during pg_upgrade |