| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Emit fewer vacuum records by reaping removable tuples during pruning |
| Date: | 2024-01-19 02:23:44 |
| Message-ID: | CAAKRu_YV-o3PQ9JHM1ux=A4juiBEPw9D_T3Xo8B17RZ=So2Fhw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 18, 2024 at 3:20 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Thu, Jan 18, 2024 at 10:09 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > Oh, I see. Good catch.
> >
> > I've now committed 0001.
>
> I have now also committed 0002 and 0003. I made some modifications to
> 0003. Specifically:
>
> - I moved has_lpdead_items inside the loop over blocks instead of
> putting it at the function toplevel.
> - I adjusted the comments in lazy_scan_prune() because it seemed to me
> that the comment about "Now scan the page..." had gotten too far
> separated from the loop where that happens.
> - I combined two lines in an if-test because one of them was kinda short.
>
> Hope that's OK with you.
Awesome, thanks!
I have attached a rebased version of the former 0004 as v11-0001.
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Combine-FSM-updates-for-prune-and-no-prune-cases.patch | text/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2024-01-19 02:51:43 | Re: the s_lock_stuck on perform_spin_delay |
| Previous Message | Peter Smith | 2024-01-19 01:00:57 | Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo |