| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Jingtang Zhang <mrdrivingduck(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Fix FSM range endpoint after relation extension |
| Date: | 2026-07-15 14:07:18 |
| Message-ID: | CAAKRu_YBS21zHHjSxQB2Ud95v0CwhsFKGi4Ddi6h7Rh=SUY3Uw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 13, 2026 at 12:28 AM Jingtang Zhang <mrdrivingduck(at)gmail(dot)com> wrote:
>
> The patches are unchanged since the original posting. The fix is a
> one-line correction to pass last_block + 1 as the exclusive endpoint
> to FreeSpaceMapVacuumRange(), and the second patch includes a focused
> test crossing an FSM leaf-page boundary.
>
> If the diagnosis and fix look reasonable, I would greatly appreciate
> a review.
Yes, this looks like a real bug and your proposed fix is the fix. In
practice, it won't affect things much -- only when the page is the
first of a new FSM page. The issue was introduced in 16, so it will
need to be backpatched all the way back. I'll try to get to it later
this week if someone else doesn't beat me to it.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-07-15 14:15:59 | Re: walsummarizer can get stuck when switching timelines |
| Previous Message | Daniel Gustafsson | 2026-07-15 14:02:31 | Re: Remove the refint contrib module (for v20) |