Re: Don't synchronously wait for already-in-progress IO in read stream

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>, Tomas Vondra <tv(at)fuzzy(dot)cz>
Subject: Re: Don't synchronously wait for already-in-progress IO in read stream
Date: 2026-03-30 19:14:49
Message-ID: CAAKRu_Y2NeYkqf1wymzErYt9aWFXU5ebUSi2xWfsv3wY4HMEbw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 30, 2026 at 3:00 PM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>
> As copperhead showed [1], tests added in 020c02bd9 fail when postgres is
> built without --enable-cassert. I've reproduced the failure locally with:

Yes, it's because read_buffers() (in test_aio.c) uses
operation->nblocks and that's only intialized for buffer hits in
assert builds. The test code could just use the correctly initialized
nblocks out parameter.

- Melanie

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-03-30 19:14:51 Re: postgres_fdw: Use COPY to speed up batch inserts
Previous Message Tom Lane 2026-03-30 19:14:30 Re: [BUG] Excessive memory usage with update on STORED generated columns.