Re: Update stale code comment in CheckpointerMain()

From: Amul Sul <sulamul(at)gmail(dot)com>
To: daniel(at)yesql(dot)se
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Update stale code comment in CheckpointerMain()
Date: 2021-12-01 06:19:05
Message-ID: CAAJ_b97cosdEvdps1cZFidC-9_sAqBqvca9bH-+QyyQJpHJUrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 30, 2021 at 3:09 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 30 Nov 2021, at 08:00, Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> > The attached patch updates the code comment which is no longer true
> > after commit # 4a92a1c3d1c361ffb031ed05bf65b801241d7cdd
>
> Agreed, but looking at this shouldn't we also tweak the comment on
> RecoveryInProgress() as per the attached v2 diff?
>

Yes, we should -- diff looks good to me, thanks.

Regards,
Amul

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2021-12-01 06:27:33 RE: Skipping logical replication transactions on subscriber side
Previous Message Bharath Rupireddy 2021-12-01 06:14:02 Re: pg_waldump stucks with options --follow or -f and --stats or -z