| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleanup - adjust the code crossing 80-column window limit |
| Date: | 2020-07-01 12:52:25 |
| Message-ID: | CAAJ_b97DsWbacuFkbqTaY0iFo7L2NSDn6h-ttiBUs4sQqC-UkA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 1, 2020 at 4:29 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> changes look good to me.
Thanks for looking at the patch.
>
> one comment: instead of having block variables onexit, in the while
> loops in shmem_exit, can we have a single local variable defined at
> the start of the shmem_exit function
> and reuse them in the while loops? same comment for onexit block
> variable in proc_exit_prepare() function.
>
If you are worried about the declaration and initialization of the variable will
happen with every loop cycle then you shouldn't because that happens only
once before the loop-block is entered.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2020-07-01 12:52:26 | Re: Add Information during standby recovery conflicts |
| Previous Message | Fujii Masao | 2020-07-01 12:50:56 | Re: max_slot_wal_keep_size and wal_keep_segments |