From: | amul sul <sulamul(at)gmail(dot)com> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | Andreas Joseph Krogh <andreas(at)visena(dot)com>, PostgreSQL General <pgsql-general(at)postgresql(dot)org> |
Subject: | Re: Exclude pg_largeobject form pg_dump |
Date: | 2016-11-04 06:52:15 |
Message-ID: | CAAJ_b979qaRa-UyOoeDE7iP0mHa5e3hRDJrXQWm6FHoZvAXEaQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Hi Guillaume,
I found following issues with this patch, sorry missed in previous post:
#1 :
43 @@ -392,6 +393,10 @@ main(int argc, char **argv)
44 dopt.outputBlobs = true;
45 break;
46
47 + case 'B': /* Don't dump blobs */
48 + dopt.include_everything = false;
49 + break;
50 +
Touching dopt.include_everything flag does not seems to be a good idea
for '--no-blobs' option, our intension is to exclude blob only, but
this excluds other dump too (e.g COMMENT ON DATABASE, CREATE
EXTENSION, COMMENT ON EXTENSION, .., etc) that what we don't want,
right?
#2 :
We should add note for default behaviour if --no-blobs & --blobs both
are specified.
Regards,
Amul Sul
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2016-11-04 08:35:49 | Re: Exclude pg_largeobject form pg_dump |
Previous Message | David Steele | 2016-11-03 15:44:29 | Re: WAL segmentes names in wrong order? |
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro HORIGUCHI | 2016-11-04 07:34:33 | Re: Radix tree for character conversion |
Previous Message | Michael Paquier | 2016-11-04 05:08:45 | Re: Gather Merge |