Re: Remove redundant variable from transformCreateStmt

On Mon, Apr 19, 2021 at 11:05 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Mon, Apr 19, 2021 at 9:32 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> > Kindly ignore the previous version -- has unnecessary change.
> > See the attached.
>
> Thanks for the patch!
>
> How about a slight rewording of the added comment to "Constraints
> validation can be skipped for a newly created table as it contains no
> data. However, this is not necessarily true for a foreign table."?
>

Well, wording is quite subjective, let's leave this to the committer
for the final decision, I don't see anything wrong with it.

> You may want to add it to the commitfest if not done already. And I
> don't think we need to backpatch this as it's not critical.

This is not fixing anything so not a relevant candidate for the backporting.

Regards,
Amul